Copy dependencies to requirements.txt in pre commit #890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-astus
force-pushed
the
copy-dependencies-to-requirements-in-pre-commit
branch
4 times, most recently
from
6d26c18 to
7e23a71
Compare
|
|
||
| def sync(): | ||
| pyproject = tomllib.loads(Path("pyproject.toml").read_text()) | ||
| dependencies = pyproject["project"]["dependencies"] |
There was a problem hiding this comment.
Are these all dependencies including dev deps or we have some development packages listed as dependencies?
coverage
There was a problem hiding this comment.
Good point, I forgot about them
sfc-gh-mraba
previously approved these changes
Mar 11, 2024
sfc-gh-astus
force-pushed
the
copy-dependencies-to-requirements-in-pre-commit
branch
4 times, most recently
from
8699c54 to
22b4ff5
Compare
Comment on lines
+58
to
+61
| - id: dependencies-sync | ||
| name: "Copy dependencies from pyproject.toml to requirements.txt" | ||
| language: system | ||
| entry: python .snyk/dependency-sync.py |
There was a problem hiding this comment.
Add files to run this only on pyproject.toml change, WDYT?
There was a problem hiding this comment.
Good idea, added
sfc-gh-astus
force-pushed
the
copy-dependencies-to-requirements-in-pre-commit
branch
3 times, most recently
from
d09ccf2 to
692252b
Compare
sfc-gh-turbaszek
approved these changes
Mar 12, 2024
sfc-gh-astus
force-pushed
the
copy-dependencies-to-requirements-in-pre-commit
branch
from
692252b to
cebc419
Compare
sfc-gh-astus
deleted the
copy-dependencies-to-requirements-in-pre-commit
branch
sfc-gh-sichen
pushed a commit
that referenced
this pull request
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-review checklist
Changes description
...