-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding app deploy command #904
Adding app deploy command #904
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, we should do the alternative suggested in the description, i.e. to have a dedicated DeployProcessor
class which will handle bundle, package creation and upload to stage without any application creation. This allows for single responsibility to be followed, in this case the ecosystem involved in app package creation.
I understand that the way this is done right now is to introduce minimal changes, perhaps as a poc. But we should refactor this properly if we are to make changes to the main branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approach LGTM, other than the one comment I have on this draft.
Closing this in favor of #921 |
Pre-review checklist
Changes description
Adding the
snow app deoply
command, which syncs the local changes to the stage without creating/updating the application (More details in SNOW-1215781).Since the deploy command is basically the same as the run command without the last step of creating/updating the application, the most minimal change would be to add a flag to skip this step in the existing
NativeAppRunProcessor
class.An alternative approach would be to add a dedicated
DeployProcessor
and refactor the common code up to the base class.The next step will be to extend the command to accept optional file paths arguments to sync only specific files:
snow app deploy [file]*
.Test
Created a basic app:
Running
deploy
with no changes:Making a change to the readme and running
deploy
again: