Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SNOW-1243569] Fixed snowpark build paths for builds with --project option #915

Merged
merged 1 commit into from
Mar 22, 2024
Merged

[SNOW-1243569] Fixed snowpark build paths for builds with --project option #915

merged 1 commit into from
Mar 22, 2024

Conversation

sfc-gh-pjob
Copy link
Contributor

@sfc-gh-pjob sfc-gh-pjob commented Mar 19, 2024 •
edited
Loading

Pre-review checklist

  • I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
  • I've added or updated automated unit tests to verify correctness of my new code.
  • I've added or updated integration tests to verify correctness of my new code.
  • I've confirmed that my changes are working by executing CLI's commands manually.
  • I've confirmed that my changes are up-to-date with the target branch.
  • I've described my changes in the release notes.
  • I've described my changes in the section below.

Changes description

@sfc-gh-turbaszek
Copy link
Contributor

Closes #906

@sfc-gh-turbaszek sfc-gh-turbaszek linked an issue Mar 20, 2024 that may be closed by this pull request
SNOW-1243569: snow build --project flag broken #906
Closed
@sfc-gh-pjob sfc-gh-pjob force-pushed the pjob/SNOW-1243569-fix-snow-build-project-path branch from 3cc96dc to 6a6b83f Compare March 21, 2024 16:44
@sfc-gh-pjob sfc-gh-pjob changed the title [SNOW-1243569] Fix snowpark build artifact path [SNOW-1243569] Fixed snowpark build paths for builds with --project option Mar 21, 2024
@sfc-gh-pjob sfc-gh-pjob marked this pull request as ready for review March 21, 2024 16:56
@sfc-gh-pjob sfc-gh-pjob requested a review from a team as a code owner March 21, 2024 16:56
sfc-gh-turbaszek
sfc-gh-turbaszek reviewed Mar 21, 2024
View reviewed changes
src/snowflake/cli/plugins/snowpark/snowpark_package_paths.py
artifact_file: SecurePath
defined_requirements_file: SecurePath = SecurePath(_DEFINED_REQUIREMENTS)
snowflake_requirements_file: SecurePath = SecurePath(_REQUIREMENTS_SNOWFLAKE)
other_requirements_file: SecurePath = SecurePath(_REQUIREMENTS_OTHER)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change the name? I never know what "other" means here

@sfc-gh-pjob sfc-gh-pjob merged commit d52fb9b into main Mar 22, 2024
10 checks passed
@sfc-gh-pjob sfc-gh-pjob deleted the pjob/SNOW-1243569-fix-snow-build-project-path branch March 22, 2024 10:07
sfc-gh-gbloom pushed a commit that referenced this pull request Mar 22, 2024
@sfc-gh-pjob @sfc-gh-gbloom
[SNOW-1243569] Fixed snowpark build paths for builds with --project o…
2887653 
…ption (#915)
sfc-gh-sichen pushed a commit that referenced this pull request Oct 17, 2024
@sfc-gh-pjob
[SNOW-1243569] Fixed snowpark build paths for builds with --project o…
2b6bdf9 
…ption (#915)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-turbaszek sfc-gh-turbaszek sfc-gh-turbaszek left review comments

@sfc-gh-pczajka sfc-gh-pczajka sfc-gh-pczajka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SNOW-1243569: snow build --project flag broken
3 participants
@sfc-gh-pjob @sfc-gh-turbaszek @sfc-gh-pczajka