-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add app deploy command #921
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good to me -- I'd like to see an integration test that confirms the existence of the app package + stage contents as there does not appear to be any additional test coverage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Cam's comment: please add relevant integration test(s) for this command.
* add app deploy command * update snapshot * add integration test * update release notes * verify manifest exists in stage
Pre-review checklist
Changes description
Adding the
snow app deoply
command, which syncs the local changes to the stage without creating/updating the application (More details in SNOW-1215781).Since the deploy command is basically the same as the run command without the last step of creating/updating the application, I moved the shared logic to the base
NativeAppManager
class.The next step will be to extend the command to accept optional file paths arguments to sync only specific files:
snow app deploy [file]*
.Test
Created a basic app:
Running
deploy
with no changes:Making a change to the readme and running
deploy
again: