Snow 1313805 fix connection test #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-pczajka
changed the base branch from
main
to
SNOW-1292755-fix-dashes-in-connection-specification
Comment on lines
20
to
24
| @contextmanager | ||
| def set_env(env_name: str, value: str): | ||
| os.environ[env_name] = value | ||
| yield | ||
| del os.environ[env_name] |
There was a problem hiding this comment.
Why not use mock.patch.dict(os.environ)?
There was a problem hiding this comment.
Fixed in #971
sfc-gh-pczajka
force-pushed
the
SNOW-1313805-fix-connection-test
branch
from
ba4c344 to
3203d36
Compare
tests/test_connection.py
Outdated
| mock.call(object_type=ObjectType.ROLE, name=f'"{conn.role}"'), | ||
| mock.call(object_type=ObjectType.DATABASE, name=f'"{conn.database}"'), | ||
| mock.call(object_type=ObjectType.SCHEMA, name=f'"{conn.schema}"'), | ||
| mock.call(object_type=ObjectType.WAREHOUSE, name=f'"{conn.warehouse}"'), |
There was a problem hiding this comment.
How it was passing previously?
There was a problem hiding this comment.
It wasn't :] - fized in #971
Base automatically changed from
SNOW-1292755-fix-dashes-in-connection-specification
to
main
April 9, 2024 11:39
sfc-gh-turbaszek
approved these changes
Apr 9, 2024
sfc-gh-sichen
pushed a commit
that referenced
this pull request
Oct 17, 2024
* fix schema override in connections test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-review checklist
Changes description
Fix overriding "schema" parameter in
snow connection test