Implement alerting using webhook #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istreeter
reviewed
Dec 13, 2023
modules/core/src/main/scala/com.snowplowanalytics.snowplow.snowflake/Run.scala
Outdated
Show resolved
Hide resolved
...les/core/src/main/scala/com.snowplowanalytics.snowplow.snowflake/processing/Processing.scala
Outdated
Show resolved
Hide resolved
modules/core/src/main/scala/com.snowplowanalytics.snowplow.snowflake/Environment.scala
Outdated
Show resolved
Hide resolved
pondzix
force-pushed
the
feature/add_monitoring
branch
4 times, most recently
from
ca18529 to
2995f70
Compare
istreeter
reviewed
Dec 19, 2023
...s/core/src/main/scala/com.snowplowanalytics.snowplow.snowflake/processing/TableManager.scala
Show resolved
Hide resolved
| import com.snowplowanalytics.snowplow.runtime.AppInfo | ||
| import io.sentry.{Sentry => JSentry, SentryOptions} | ||
|
|
||
| object Sentry { |
There was a problem hiding this comment.
This is a good candidate to eventually move to the common libs. Unfortunately we cannot do that yet, because we are still using a mixture of sentry sdk versions. We can migrate it after we have consolidated on the newer sentry.
modules/core/src/main/scala/com.snowplowanalytics.snowplow.snowflake/Alert.scala
Show resolved
Hide resolved
istreeter
approved these changes
Dec 20, 2023
pondzix
force-pushed
the
feature/add_monitoring
branch
from
3237fe5 to
d149bd6
Compare
istreeter
pushed a commit
that referenced
this pull request
Feb 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3 kinds of alerts are sent using configured webhook:
New config looks like:
New iglu schema for alert - snowplow/iglu-central#1363