Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acquiring channel should not block graceful shutdown #14

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

istreeter
Copy link
Collaborator

@pondzix I think we need this small amendment.

If we can't create the channel, then we expect kubernetes to eventually send a SIGTERM to the app. When that happens, we want the app to shutdown gracefully as quickly as possible.

But the acquire block of a resource is uncancelable. So instead of shutting down on the SIGTERM, it will continue to retry indefinitely (until Kubernetes eventually hard-kills it with a SIGKILL).

We can fix it by switching make to makeFull and then use the Poll so that the acquire is cancelable.

@istreeter istreeter merged commit a90ab76 into develop Jan 3, 2024
2 checks passed
@istreeter istreeter deleted the channel-make-full branch January 3, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants