Acquiring channel should not block graceful shutdown #14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pondzix I think we need this small amendment.
If we can't create the channel, then we expect kubernetes to eventually send a SIGTERM to the app. When that happens, we want the app to shutdown gracefully as quickly as possible.
But the
acquire
block of a resource is uncancelable. So instead of shutting down on the SIGTERM, it will continue to retry indefinitely (until Kubernetes eventually hard-kills it with a SIGKILL).We can fix it by switching
make
tomakeFull
and then use thePoll
so that theacquire
is cancelable.