Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not decode iglu json webhook ue_pr paramter on coerce #144

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

peel
Copy link
Contributor

@peel peel commented Jun 26, 2024

When attempting convering RawEvent into CollectorPayload we previously
were convering it through proper JSON decoder. But as this is already
manually modified through recovery process we can skip decoding and
instead simply pass the JSON.
Otherwise we'd need to alter RawEvent to contain body field which it
is missing. And we cannot.


@github-actions github-actions bot added the bug Something isn't working label Jun 26, 2024
peel added 2 commits June 26, 2024 18:03
When attempting convering RawEvent into CollectorPayload we previously
were convering it through proper JSON decoder. But as this is already
manually modified through recovery process we can skip decoding and
instead simply pass the JSON.
Otherwise we'd need to alter RawEvent to contain `body` field which it
is missing. And we cannot.
@peel peel force-pushed the bug/do-not-decode-iglu-json branch from 0bde359 to b1961c3 Compare June 26, 2024 16:03
@peel peel merged commit 7bdb9ef into develop Jun 26, 2024
2 checks passed
@peel peel deleted the bug/do-not-decode-iglu-json branch June 26, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant