Validate atomic fields lengths and max JSON depth with Enrich defaults #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjben
force-pushed
the
PDP-1583_atomic_fields_lengths
branch
2 times, most recently
from
b2c9d63 to
d9a624c
Compare
benjben
changed the title
peel
approved these changes
Nov 25, 2024
istreeter
approved these changes
Nov 25, 2024
|
|
||
| if (unsupportedFields.nonEmpty) | ||
| Left(s""" | ||
| |Configured atomic fields: ${unsupportedFields.mkString("[", ",", "]")} are not supported. |
There was a problem hiding this comment.
Presumably nobody will ever see this error message if field lengths are not configurable?
There was a problem hiding this comment.
Yeah I hesitated to remove it. I thought that we might make this configurable one day in Micro and this will become useful. But I'm fine with removing it if you think that I should
There was a problem hiding this comment.
I think it's fine to leave it, for the reasons you say.
benjben
force-pushed
the
PDP-1583_atomic_fields_lengths
branch
from
d9a624c to
5c3dae6
Compare
benjben
force-pushed
the
PDP-1583_atomic_fields_lengths
branch
from
5c3dae6 to
b8aad70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use defaults from https://github.com/snowplow/enrich-private/blob/PDP-1583_mico_atomic_lengths/modules/common/src/main/resources/reference.conf#L152-L240