Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): 🎨 follow new poetry core namespace #159

Merged
merged 2 commits into from
Jul 18, 2023

Conversation

blaggacao
Copy link
Contributor

Why is this required?

Prior to the release of version 1.1.0, Poetry was a project management tool that included a PEP 517 build backend. This was inefficient and time consuming when a PEP 517 build was required. For example, both pip and tox (with isolated builds) would install Poetry and all dependencies it required. Most of these dependencies are not required when the objective is to simply build either a source or binary distribution of your project.

See: https://github.com/python-poetry/poetry-core

@blaggacao
Copy link
Contributor Author

Has been solicited by code owners for nixpkgs packaging of this module.

@blaggacao
Copy link
Contributor Author

Hi @MerleLiuKun , would it be possible to get your quick attention on this small amendment?

@MerleLiuKun
Copy link
Member

oh, Yes poetry has changed. I will check this quickly.

@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (99d7a2c) 100.00% compared to head (872e4f7) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #159   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           53        53           
  Lines         2119      2119           
=========================================
  Hits          2119      2119           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MerleLiuKun MerleLiuKun merged commit 633325e into sns-sdks:master Jul 18, 2023
@blaggacao
Copy link
Contributor Author

Thank you for considering this contribution.

Would it be possible to ask for a new patch release (github tag), so that I could use that released version downstream for packaging?

@MerleLiuKun
Copy link
Member

I have publish a patch v0.9.1 for this update. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants