Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

Third-party package download does not follow redirects #21

Open
dcupif opened this issue Sep 3, 2019 · 2 comments · May be fixed by #22
Open

Third-party package download does not follow redirects #21

dcupif opened this issue Sep 3, 2019 · 2 comments · May be fixed by #22

Comments

@dcupif
Copy link

dcupif commented Sep 3, 2019

Hi,

Thanks for the project, it really is awesome and I've been looking for something like this for quite a while already. 👏

While extending the project to install the latest release of bat, I wanted to reuse the install functions provided, more specifically the install_remote_package option. To this end, I get the latest release from github using their API, but the download url I get from them makes a redirect which curl does not follow since only the -O flag is used.

Is there a particular reason why you did this way, or should we just add the -L flag to follow redirects?
@snwh
Copy link
Owner

snwh commented Sep 6, 2019

I have no reason for this, if you have a better way do open a PR. :)

@dcupif dcupif linked a pull request Sep 9, 2019 that will close this issue
Open
@dcupif
Copy link
Author

dcupif commented Sep 9, 2019

Done, I checked for others occurrences of curl, but I think it only makes sense to change it for the generic install functions. Let me know what you think. I also made the download display silent, though it will still print errors if any.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Follow redirects on curl downloads dcupif/ubuntu-post-install
2 participants
@snwh @dcupif