From a0582e74f9c3145d265bbc528369fa394e642949 Mon Sep 17 00:00:00 2001 From: Nathan Moinvaziri Date: Fri, 29 Dec 2023 06:30:44 -0800 Subject: [PATCH] Revert "AIR-9: Do not cancel stackwalk when module not found." This reverts commit 8b84378664c97c9e03ba62226e542ce7c25d2777. --- src/processor/stack_frame_symbolizer.cc | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/processor/stack_frame_symbolizer.cc b/src/processor/stack_frame_symbolizer.cc index 1401193d2..3afd471b8 100644 --- a/src/processor/stack_frame_symbolizer.cc +++ b/src/processor/stack_frame_symbolizer.cc @@ -79,9 +79,7 @@ StackFrameSymbolizer::SymbolizerResult StackFrameSymbolizer::FillSourceLineInfo( // If module is known to have missing symbol file, return. if (no_symbol_modules_.find(module->code_file()) != no_symbol_modules_.end()) { - //BZ: Previously, this would generate an error, which would cancel - // the remainder of the stackwalk. - return kNoError; + return kError; } // If module is already loaded, go ahead to fill source line info and return. @@ -118,11 +116,9 @@ StackFrameSymbolizer::SymbolizerResult StackFrameSymbolizer::FillSourceLineInfo( return resolver_->IsModuleCorrupt(frame->module) ? kWarningCorruptSymbols : kNoError; } else { - //BZ: Previously, this would generate an error, which would cancel - // the remainder of the stackwalk. BPLOG(ERROR) << "Failed to load symbol file in resolver."; no_symbol_modules_.insert(module->code_file()); - return kNoError; + return kError; } }