Skip to content

Commit

Permalink
Revert "AIR-9: Do not cancel stackwalk when module not found."
Browse files Browse the repository at this point in the history
This reverts commit 8b84378.
  • Loading branch information
nmoinvaz committed Jul 24, 2024
1 parent bd1d966 commit a1795eb
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions src/processor/stack_frame_symbolizer.cc
Original file line number Diff line number Diff line change
Expand Up @@ -79,9 +79,7 @@ StackFrameSymbolizer::SymbolizerResult StackFrameSymbolizer::FillSourceLineInfo(
// If module is known to have missing symbol file, return.
if (no_symbol_modules_.find(module->code_file()) !=
no_symbol_modules_.end()) {
//BZ: Previously, this would generate an error, which would cancel
// the remainder of the stackwalk.
return kNoError;
return kError;
}

// If module is already loaded, go ahead to fill source line info and return.
Expand Down Expand Up @@ -118,11 +116,9 @@ StackFrameSymbolizer::SymbolizerResult StackFrameSymbolizer::FillSourceLineInfo(
return resolver_->IsModuleCorrupt(frame->module) ?
kWarningCorruptSymbols : kNoError;
} else {
//BZ: Previously, this would generate an error, which would cancel
// the remainder of the stackwalk.
BPLOG(ERROR) << "Failed to load symbol file in resolver.";
no_symbol_modules_.insert(module->code_file());
return kNoError;
return kError;
}
}

Expand Down

0 comments on commit a1795eb

Please sign in to comment.