Skip to content

Commit

Permalink
AIR-8: do not cancel stackwalk when module not found.
Browse files Browse the repository at this point in the history
  • Loading branch information
bozimmerman authored and nmoinvaz committed Dec 20, 2023
1 parent ca6cb3c commit efc8cf6
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions src/processor/stack_frame_symbolizer.cc
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,9 @@ StackFrameSymbolizer::SymbolizerResult StackFrameSymbolizer::FillSourceLineInfo(
// If module is known to have missing symbol file, return.
if (no_symbol_modules_.find(module->code_file()) !=
no_symbol_modules_.end()) {
return kError;
//BZ: Previously, this would generate an error, which would cancel
// the remainder of the stackwalk.
return kNoError;
}

// If module is already loaded, go ahead to fill source line info and return.
Expand Down Expand Up @@ -116,9 +118,11 @@ StackFrameSymbolizer::SymbolizerResult StackFrameSymbolizer::FillSourceLineInfo(
return resolver_->IsModuleCorrupt(frame->module) ?
kWarningCorruptSymbols : kNoError;
} else {
//BZ: Previously, this would generate an error, which would cancel
// the remainder of the stackwalk.
BPLOG(ERROR) << "Failed to load symbol file in resolver.";
no_symbol_modules_.insert(module->code_file());
return kError;
return kNoError;
}
}

Expand Down

0 comments on commit efc8cf6

Please sign in to comment.