fix: view management, don't show trust & connect when not needed #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastiandoetsch
force-pushed
the
fix/HEAD-655_VS-Code-Extension-Trustworkspace-and-connect-message-persists
branch
from
4e58bed
to
6396f6b
Compare
Signed-off-by: Bastian Doetsch <bastian.doetsch@snyk.io>
Signed-off-by: Bastian Doetsch <bastian.doetsch@snyk.io>
Signed-off-by: Bastian Doetsch <bastian.doetsch@snyk.io>
bastiandoetsch
force-pushed
the
fix/HEAD-655_VS-Code-Extension-Trustworkspace-and-connect-message-persists
branch
from
6396f6b
to
fb90097
Compare
cat2608
reviewed
Sep 29, 2023
cat2608
reviewed
Sep 29, 2023
Comment on lines
+9
to
+11
| // eslint-disable-next-line @typescript-eslint/no-unused-vars,@typescript-eslint/no-explicit-any | ||
| declare const acquireVsCodeApi: any; | ||
|
|
There was a problem hiding this comment.
Is it correct to say that this package could bring the types we need?
DefinitelyTyped/DefinitelyTyped#53370
https://www.npmjs.com/package/@types/vscode-webview
If so, do you think we could start using them?
There was a problem hiding this comment.
Yes, let's do that, but put that into a different PR
cat2608
reviewed
Sep 29, 2023
Comment on lines
-104
to
+107
| lineOnly: !!lineOnly, | ||
| lineOnly: lineOnly, |
There was a problem hiding this comment.
This operator forces the conversion of truthy/falsy values to primitive booleans. Do we need to work with loose truthy/falsy values?
There was a problem hiding this comment.
This seems to be a guaranteed boolean, so we don't need the forced conversion.
Signed-off-by: Bastian Doetsch <bastian.doetsch@snyk.io>
bastiandoetsch
deleted the
fix/HEAD-655_VS-Code-Extension-Trustworkspace-and-connect-message-persists
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, during plugin startup, "trust & connect" was shown in the welcome dialog. Now, during startup, a message is shown that the plugin is still starting. Views are now initialized with reasonable defaults and only displayed when needed.
Also removed the "feature select" view that was not shown anymore anyway. Boy Scouts Rule!
Checklist
Screenshots / GIFs
Before:
https://github.com/snyk/vscode-extension/assets/20150761/fdeb9a93-1f4c-4831-95c2-1d0c2eeb8eb2
Screenrecording After:
https://github.com/snyk/vscode-extension/assets/20150761/d2ae2c58-0721-45ac-9690-7083b9ec7d47