Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: history bugs #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

inevermore
Copy link

No description provided.

@soccerloway
Copy link
Owner

@inevermore Thanks for your PR.
When I apply your changes, the top column tool missed. And 'merge cells' did not work as usual.

@inevermore
Copy link
Author

@soccerloway I didn't check all, just try to fix the history bug. Hope this pr can help you:smile:

@soccerloway
Copy link
Owner

@inevermore Thank you, your changes must be useful~:)
It make insert/delete undo works well.

@kagol
Copy link

kagol commented Oct 9, 2019

Thanks for your fixing, but will this change have side effects?

@soccerloway
Copy link
Owner

@kagol This is not a rigorous fixing, but inspiring.
Don't use it for now.

@kagol
Copy link

kagol commented Oct 14, 2019

This will cause some side effect when table has rowspan/colspan(initial/paste)

@inevermore
Copy link
Author

@kagol Yes, this is not a qualified pr. I just focus on history bug. Hope this can inspire you.

@inevermore
Copy link
Author

打个广告~
@soccerloway @kagol
钉钉文档招聘前端/java岗位,海量hc,急召p6/p7/p8(杭州/北京)
团队成员:微软技术专家、antd pro人员等
有兴趣可以加我微信:877089265
没兴趣也可以加,交个朋友哈~

@kagol
Copy link

kagol commented Oct 17, 2019

@inevermore Thank you anyway~

@sirgru
Copy link

sirgru commented Dec 11, 2019

Any progress on this issue?

@soccerloway
Copy link
Owner

Actually no. I think it will take much time to fix the issue, but I'm busy in the end of the year.
I'm sorry for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants