Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate the tool of inserting table into the toolbar module of quill (Fix #34) #56

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

simialbi
Copy link

I built a module out of Rudy's solution and tried to do like official Quill Pickers. The integration was not possible without extending the Snow Theme.
The solution looks like this:
image

Usage

var quill = new Quill("#quill-div", {
    "theme": "better-table-snow",
    "modules": {
        "better-table": [],
        "keyboard": {
            "bindings": quillBetterTable.keyboardBindings
        },
        "toolbar": [
            ["clean"],
            [{
                "list": "ordered"
            }, {
                "list": "bullet"
            }],
            [{
                "indent": "-1"
            }, {
                "indent": "+1"
            }],
            ["bold", "italic", "underline", "strike", {
                "script": "super"
            }, {
                "script": "sub"
            }],
            ["link", {
                "better-table": []
            }]
        ]
    }
});

I also added some little changes in code (e.g. split up built process to make parts of them work under windows or pass empty object as oprationMenu config if none set).

@delewis13
Copy link

@simialbi thanks for this work, have also integrated and it works nicely. Performance when inserting larger tables is slow however - any ideas how to fix?

@simialbi
Copy link
Author

Could not reproduce it. Which size are you talking about?

@delewis13
Copy link

delewis13 commented Jun 23, 2020 via email

# Conflicts:
#	dist/demo/demo1.js
#	dist/quill-better-table.js
# Conflicts:
#	dist/demo/demo1.js
#	dist/quill-better-table.js
#	dist/quill-better-table.min.js
# Conflicts:
#	dist/demo/demo1.js
#	dist/quill-better-table.js
@Daedra22
Copy link

why don't you merge it ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants