Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for RBS #64

Open
ioquatix opened this issue Apr 17, 2020 · 3 comments
Open

Add support for RBS #64

ioquatix opened this issue Apr 17, 2020 · 3 comments

Comments

@ioquatix
Copy link
Member

@soutaro What is the process to create/add RBS to this project? I would love to add it and expose users downstream to it, and maybe catch bugs with it too!

@havenwood
Copy link
Contributor

It would be awesome to add type signatures for Async to the ruby/gem_rbs_collection repo where RBS type signatures are being collected for gems.

@havenwood
Copy link
Contributor

Just adding a note to please disregard my last comment since I was confused.

I was talking with @soutaro today about ruby/gem_rbs_collection and it made me realize I totally misunderstood the purpose of the repo. Soutaro mentioned contributing to the gem_rbs_collection is really just for gem signatures maintained by someone outside the gem project. When the project maintainer wants to add signatures, contributors can just use a local sig/ directory in the gem.

@ioquatix
Copy link
Member Author

ioquatix commented Nov 1, 2022

I've thought about this.

I prefer to write the documentation and type signature in the code, as it's currently done.

Then, I want to convert this to RBS type signatures, and incorporate that where possible into type checking/documentation/etc.

I don't want to manually maintain the type signature nor do I think it should be in a separate gem (easy to get out of sync).

@soutaro do you have any thoughts or suggestions about how we can make this work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants