Use GC_memalign for larger allocations #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we add a test for this? |
|
Sure: ba2e09d |
|
Please squash. |
When a layout's alignment is larger than its size, we must allocate using Boehm's `memalign` function instead of `malloc` in order to mirror the existing behaviour in rustc. This is checked in rustc with various assertions on pointer read and write intrinsics, and was discovered when they failed with large alloctions in lrlex using a debug build of alloy.
jacob-hughes
force-pushed
the
memaligned_malloc
branch
from
ba2e09d
to
339fdb6
Compare
|
Squashed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a layout's alignment is larger than its size, we must allocate using Boehm's
memalignfunction instead ofmallocin order to mirror the existing behaviour in rustc.This is checked in rustc with various assertions on pointer read and write intrinsics, and was discovered when they failed with large alloctions in lrlex using a debug build of alloy.