-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run Boehm assertions on CI #102
Conversation
I've fixed the various test failures here: 77872b6. If all looks good, can I squash? |
Please squash. |
77872b6
to
6a18017
Compare
Squashed |
This test failure is to do with the flaky nature of how we test that finalisers have run. We have to remove references to objects in order for them to die and then be finalised and on bencher16, it's enough to create a new on-stack-pointer to overwrite the old one. Unfortunately this doesn't seem to work on CI (because really we're in UB territory here). The problem is that the last reference to an object in a tight loop sometimes lingers, so I suggest we modify this test from:
to:
|
@jacob-hughes Works for me! |
[Provided we add a nice long comment explaining why the test is a bit weaker than one might first expect.] |
How about something like this? 915649d |
Fixed a typo here 4067bc5 |
Please squash. |
This also fixes several tests which previously passed when GC asserts were disabled.
4067bc5
to
7540667
Compare
Squashed |
No description provided.