Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Boehm assertions on CI #102

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

jacob-hughes
Copy link
Collaborator

No description provided.

@ltratt ltratt added this pull request to the merge queue Dec 4, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 4, 2023
@ltratt ltratt added this pull request to the merge queue Dec 5, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 5, 2023
@jacob-hughes
Copy link
Collaborator Author

I've fixed the various test failures here: 77872b6. If all looks good, can I squash?

@ltratt
Copy link
Member

ltratt commented Dec 5, 2023

Please squash.

@jacob-hughes
Copy link
Collaborator Author

Squashed

@ltratt ltratt added this pull request to the merge queue Dec 5, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 5, 2023
@jacob-hughes
Copy link
Collaborator Author

This test failure is to do with the flaky nature of how we test that finalisers have run. We have to remove references to objects in order for them to die and then be finalised and on bencher16, it's enough to create a new on-stack-pointer to overwrite the old one. Unfortunately this doesn't seem to work on CI (because really we're in UB territory here).

The problem is that the last reference to an object in a tight loop sometimes lingers, so I suggest we modify this test from:

assert_eq!(finalisers_run, expected_finalisers_run)

to:

assert!(finalisers_run >= expected_finalisers_run - 1)

@ltratt
Copy link
Member

ltratt commented Dec 5, 2023

@jacob-hughes Works for me!

@ltratt
Copy link
Member

ltratt commented Dec 5, 2023

[Provided we add a nice long comment explaining why the test is a bit weaker than one might first expect.]

@jacob-hughes
Copy link
Collaborator Author

How about something like this? 915649d

@jacob-hughes
Copy link
Collaborator Author

Fixed a typo here 4067bc5

@ltratt
Copy link
Member

ltratt commented Dec 6, 2023

Please squash.

This also fixes several tests which previously passed when GC asserts
were disabled.
@jacob-hughes
Copy link
Collaborator Author

Squashed

@ltratt ltratt added this pull request to the merge queue Dec 6, 2023
Merged via the queue into softdevteam:master with commit 1cc2852 Dec 6, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants