Add env var for specifying custom BDWGC path #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is very useful for debugging Alloy.
ltratt
reviewed
Jan 18, 2024
library/boehm/build.rs
Outdated
| @@ -5,8 +5,8 @@ use std::process::Command; | |||
|
|
|||
| const BOEHM_REPO: &str = "https://github.com/softdevteam/bdwgc.git"; | |||
| const BOEHM_ATOMICS_REPO: &str = "https://github.com/ivmai/libatomic_ops.git"; | |||
| const BOEHM_DIR: &str = "bdwgc"; | |||
| const BUILD_DIR: &str = "lib"; | |||
| const BOEHM_DEFAULT_SRC_DIR: &str = "bdwgc"; | |||
There was a problem hiding this comment.
Should we consistently call this BDWGC (including the env var etc)?
There was a problem hiding this comment.
I think so really yeah. I'll push an update.
There was a problem hiding this comment.
Since this PR is really just a bunch of miscellaneous fixes, I've decided to go ahead and fix this across the entire codebase: 6cfff56
|
Do you want to squash? |
|
No, I think these commits should be separate. If you're ok with that, this is ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.