Add wrapper type for opting out of FSA #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we add a test that makes it clear that this still runs finalisers, even if they're not obviously safe? |
|
Sure |
|
Before I can push a finaliser test for this, #87 will need merging. |
|
Works for me -- please squash. |
This can be very useful when using types from third party crates which do not implement `FinalizerSafe`. Instead of implementing `FinalizerSafe` on any `T` with a `!FinalizerSafe` field, we can now ensure each problematic field uses the `FinalizeUnchecked<U>` wrapper. This is safer than a blanket implementation.
jacob-hughes
force-pushed
the
finalize_unchecked
branch
from
d36668c
to
a27007d
Compare
|
Squashed |
|
bors r+ |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be very useful when using types from third party crates which do not implement
FinalizerSafe. Instead of implementingFinalizerSafeon anyTwith a!FinalizerSafefield, we can now ensure each problematic field uses theFinalizeUnchecked<U>wrapper. This is safer than a blanket implementation.