Lazily spawn finalisation thread #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the canonical place for globals and ensures that they are included in the right object files.
ltratt
reviewed
Apr 16, 2024
fnlz_mlc.c
Outdated
| pthread_t t; | ||
| pthread_create(&t, NULL, init_finalize_thread, NULL /* arg */); | ||
| GC_finalizer_thread_exists = 1; | ||
|
|
ltratt
reviewed
Apr 16, 2024
| @@ -2069,9 +2069,11 @@ GC_API void GC_CALL GC_enable(void) | |||
| LOCK(); | |||
| GC_ASSERT(GC_dont_gc != 0); /* ensure no counter underflow */ | |||
| GC_dont_gc--; | |||
| #ifndef BUFFERED_FINALIZATION | |||
There was a problem hiding this comment.
When we allocate the pages for the finaliser buffer, we do so from within the STW pause which can cause the heap to grow if lots of objects are enqueued for finalisation in a single GC. This WARN prints to stderr anytime the heap grows, and in alloy tests this can cause spurious output which causes a test to fail because stderr does not match.
I probably should have made this a separate commit, happy for me to do so when I squash?
There was a problem hiding this comment.
I probably should have made this a separate commit, happy for me to do so when I squash?
Works for me!
|
Please squash. |
This ensures that the synchronisation cost of spawning the finalisation thread is only spent when a) the program contains finalisers, and b) dead objects become finalisable candidates.
The allocation of pages for the finaliser buffer is done from within the STW pause. This can cause the heap to grow if lots of objects are enqueued for finalisation in a single GC and can cause spurious warnings to be printed to stderr.
jacob-hughes
force-pushed
the
lazy_finalization
branch
from
c1d312d
to
fd7ce82
Compare
|
Squashed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that the synchronisation cost of spawning the finalisation thread is only spent when a) the program contains finalisers, and b) dead objects become finalisable candidates.