Fix pattern error report bug #46
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the `..~` operator, it could eventually match after having failed several times, and accidentally increment the apparent line the pattern failed to match at. This didn't affect the matching algorithm, but meant that a failure to match would report the wrong position in the pattern. The new test line below incorrectly reported `(8, 6)` before the fix in this commit.
When `...` fails to match it (sensibly) tells you that the error was on the of the pattern *after* the `...`, but `..~` reported the pattern line itself. This commit makes `..~` follow `...`s behaviour.
|
Closing as I've spotted another one, so I might as well try and do this in one shot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix in ba7da28, which made me realise I could then do a minor simplification (2f9d8f2). I then spotted another related pattern reporting error in 9794e4e.