Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Errors in catching incorrectly terminated productions #463

Closed
bendrissou opened this issue Jun 13, 2024 · 4 comments · Fixed by #464
Closed

Errors in catching incorrectly terminated productions #463

bendrissou opened this issue Jun 13, 2024 · 4 comments · Fixed by #464

Comments

@bendrissou
Copy link
Contributor

bendrissou commented Jun 13, 2024 •
edited
Loading

Hi,

After the last merge, some of my projects are failing to build.

error: failed to run custom build command for `lua_repair v0.1.0 (/home/rust/lua_repair)`

Caused by:
  process didn't exit successfully: `/home/rust/target/release/build/lua_repair-162ad1ab4214539c/build-script-build` (exit status: 101)
  --- stderr
  thread 'main' panicked at lua_repair/build.rs:14:10:
  called `Result::unwrap()` on an `Err` value: 
  	Production not terminated correctly at line 73 column 5
  	Unknown reference to rule 'retstatopt' at line 65 column 19
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
warning: build failed, waiting for other jobs to finish...

I don't think I have any grammar rules of the form:

R: A {B} C;

But I do have rules like:

R: A {B} 
 | {C};

Do you think that is an incorrectly terminated production?

Thank you.
@bendrissou bendrissou changed the title Errors: catching incorrectly terminated productions Errors in catching incorrectly terminated productions Jun 13, 2024
@ltratt ltratt mentioned this issue Jun 13, 2024
Merged
@ltratt
Copy link
Member

ltratt commented Jun 13, 2024

@bendrissou Can you send me a complete grammar that shows this problem please? I may well have made a mistake!

ltratt added a commit to ltratt/grmtools that referenced this issue Jun 13, 2024
@ltratt
Unbreak empty productions and actions.
e077e02 
This is a classic copy and paste mistake on my part: I didn't think
carefully enough about the `syms.is_empty()` clause.

Problem reported by Bachir Bendrissou in
softdevteam#463.
ltratt added a commit to ltratt/grmtools that referenced this issue Jun 13, 2024
@ltratt
Unbreak empty productions and actions.
2b1a4e8 
This is a classic copy and paste mistake on my part: I didn't think
carefully enough about the `syms.is_empty()` clause.

Fixes softdevteam#463.
@ltratt
Copy link
Member

ltratt commented Jun 13, 2024

I can confirm that this is due to a mistake on my part -- thanks for reporting!

@ltratt ltratt mentioned this issue Jun 13, 2024
Merged
@ltratt
Copy link
Member

ltratt commented Jun 13, 2024

@bendrissou This should now be fixed.

@bendrissou
Copy link
Contributor Author

Thank you for the prompt fix. Things are looking good now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unbreak empty productions and actions. ltratt/grmtools
2 participants
@ltratt @bendrissou