Give better warnings if lexer/grammar can't be read at build time. #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the user gave an incorrect path, they got an internal `unwrap`, or similarly unhelpful message, from lrlex and lrpar. This commit tells them what file was attempting to be read, which makes working out what's actually gone wrong much easier.
ratmice
approved these changes
Jun 4, 2024
|
@ratmice Feel free to press the "merge" button if the PR works for you -- you have full rights on this repo! |
|
Thanks, I was just about to ask about how we want to handle that since things have changed a little bit in the review process now that we don't use bors any longer. |
|
Yeah it's a bit messy, but the "merge" button hands things over to Buildbot, at which point it's the same as the bors days! I mostly miss |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user gave an incorrect path, they got an internal
unwrap, or similarly unhelpful message, from lrlex and lrpar. This commit tells them what file was attempting to be read, which makes working out what's actually gone wrong much easier.