Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run() exits #89

Open
vext01 opened this issue May 26, 2021 · 3 comments
Open

run() exits #89

vext01 opened this issue May 26, 2021 · 3 comments
Assignees

Comments

@vext01
Copy link
Member

vext01 commented May 26, 2021

I have a branch on yk where the test harness runs the same tests with different flags. Each configuration sets up and tears down a dedicated lang_tester session.

I was surprised that testing ended after the first lang_tester session with errors was encountered. This is because run() exits.

I wonder, should we return a status to the caller, who can then decide what to do with failures?

@ltratt
Copy link
Member

ltratt commented Jun 21, 2021

Good question. lang_tester is slightly odd in that there are various places where it will simply exit when it finds a problem -- but most of those are of the form "the test input is ill-formed". The problem here is that I'm not sure what the right return type might be. Result<(), ()> feels a bit lame, but maybe it would be the least worst choice?

@vext01
Copy link
Member Author

vext01 commented Jun 21, 2021

How about Result<(), std::process::ExitStatus>?

@ltratt
Copy link
Member

ltratt commented Jun 21, 2021

Hmm, interesting. Let me chew on it for a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants