Test authentication. #123
Merged
Test authentication. #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a sense these tests are the two most important missing tests, because they're what give confidence that snare is only executing commands when the request is properly authenticated.
vext01
reviewed
Dec 19, 2023
| // Takes the example from [full_request], alters the client-side secret, and checks that this | ||
| // causes snare not execute any commands (so, by proxy, we assume that authentication failed). | ||
|
|
||
| let td = Builder::new().tempdir_in(env!("CARGO_TARGET_TMPDIR"))?; |
There was a problem hiding this comment.
Let's lift the common setup into a function?
There was a problem hiding this comment.
The next PR will do just that :)
vext01
reviewed
Dec 19, 2023
| }} | ||
| }}"# | ||
| ), | ||
| move |_| { |
There was a problem hiding this comment.
I'm struggling to find the bit where you check that it failed.
There was a problem hiding this comment.
We (indirectly, which is the best we can do) check that the action wasn't executed (i.e. the named temporary file wasn't created) in https://github.com/softdevteam/snare/pull/123/files#diff-e41c063cd26a1181211ca22e91577e32d5067e01cf8f6341954e708842bf5f07R296.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a sense these tests are the two most important missing tests, because they're what give confidence that snare is only executing commands when the request is properly authenticated.