Use a Makefile that does a more portable installation. #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is based on recent changes to pizauth's Makefile. It respects `$DESTDIR` and also installs man pages in the correct (different!) location on both BSD and Linux. The downside is that the Makefile is now GNU make only.
vext01
reviewed
Jan 8, 2024
| MANDIR.${PREFIX} = ${PREFIX}/share/man | ||
| MANDIR./usr/local = /usr/local/man | ||
| MANDIR. = /usr/share/man | ||
| MANDIR ?= ${MANDIR.${PREFIX}} |
There was a problem hiding this comment.
Your GNU foo is better than mine. How does this alter the man directory based on platform? Does it rely on one of the platforms passing ${PREFIX} at build time?
There was a problem hiding this comment.
It was a suggestion by someone else -- I wouldn't have thought of this! Basically if you pass PREFIX=/usr/local then MANDIR is set to /usr/local/man, otherwise it's set to /usr/share/man. It's very cunning!
There was a problem hiding this comment.
I bet there's a platform where PREFIX=/usr/local/, but the manuals go into /usr/local/share/man, but let's not worry about it until we see it.
I thought FreeBSD did it this way, but I just check and I was wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on recent changes to pizauth's Makefile. It respects
$DESTDIRand also installs man pages in the correct (different!) location on both BSD and Linux. The downside is that the Makefile is now GNU make only.