Handle both JSON and urlencoded requests.

[ltratt]

I singularly failed to realise that GitHub requests can come with a Content-Type of JSON or urlencoded: previously snare only handled the latter. Handling both automatically is fairly easily, but doing so highlighted that the tests incorrectly said they had JSON content-type but were actually urlencoded. Since JSON content-type is easier to understand, the tests now consistently use that, except for a (new) test to ensure that we really handle urlencoded correctly.

@mweitzel Does this work for your repo(s) on both JSON and urlencoded webhooks?

[mweitzel]

Oh man, this is great! Pulled/built/tested, all works quite well with both webhook configurations. Thank you.

FYI, using the json content type also resolve some percent-encoding vs url-encoding headaches. Where you get + instead of %20 so just a "percent decode" misses it. E.g.

$ diff json-webhook.json form-encode-webhook.json 
+  "title": "Create asdf",
-  "title": "Create+asdf",
...
+  "description": "test webhooks and whatnot",
-  "description": "test+webhooks+and+whatnot",

This patch is great, IMO. It now supports json webhooks which it did not before, and the behavior for form-encoded webhooks is entirely consistent with what it was before.

[ltratt]

Thanks for testing! It was a good bug report which made the fix obvious -- my favourite :)

[vext01]

LGTM