[ts-sdk][demos] Set up pnpm workspaces, update eslint config, update ts config #830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrtqKr
changed the title
wkozyra95
reviewed
Oct 28, 2024
ts/package.json
Outdated
| "watch": "lerna run --parallel --stream watch --private", | ||
| "lint": "pnpm -r run lint", | ||
| "lint:fix": "pnpm -r run lint -- --fix", | ||
| "build": "pnpm -r --no-sort --filter ./packages/* run build", |
ts/pnpm-workspace.yaml
Outdated
| - 'examples/vite-browser-render' | ||
| - 'create-live-compositor' | ||
| - 'create-live-compositor/templates/node-minimal' | ||
| - 'create-live-compositor/templates/node-express-zustand' |
There was a problem hiding this comment.
fix newlines (few other files also have that)
| @@ -1,5 +1,6 @@ | |||
| import * as Api from '../api.js'; | |||
| import { createCompositorComponent, SceneComponent } from '../component.js'; | |||
| import type * as Api from '../api.js'; | |||
There was a problem hiding this comment.
Was type necessary here for building or is this just a preference?
There was a problem hiding this comment.
preference - I like to have it enforced because you're able to easily tell the types and other things apart form each other. Overall, I've placed this rule for every subdir in ts
wkozyra95
approved these changes
Oct 31, 2024
| "@types/react-reconciler": "0.28.8" | ||
| }, | ||
| "dependencies": { | ||
| "react-reconciler": "0.29.2" | ||
| }, | ||
| "peerDependencies": { | ||
| "live-compositor": "^0.1.0" | ||
| "react": "^18.3.1", |
There was a problem hiding this comment.
Suggested change
| "react": "^18.3.1", | |
| "react": "*", |
we need to have a large range, if I remember correctly more than one react in app will not work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.