-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Don't call
jsQueue->quitSynchronous()
immediately after construction (
#6781) ## Summary This PR moves `jsQueue->quitSynchronously()` calls from `ReanimatedRuntime::make` or `ReanimatedHermesRuntime` constructor to `~WorkletsModuleProxy` as well as simplifies the logic. I had to add `(void)jsQueue;` to avoid a warning due to unused variable. ## Test plan > [!NOTE] > I have tested this PR only on iOS Fabric in debug mode. Please test it thoroughly across platforms, runtimes and build configurations prior to merging.
- Loading branch information
Showing
3 changed files
with
3 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters