fix: Fix static view config validation for RNSVGSvgViewAndroid #2274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @fabriziocucci, 
|
|
@jakex7 thanks for raising the question, these are unfortunately two separate but connected problems. This diff is a workaround to fix the static view config validation (similarly to what was already done in the past here). For the pre-existing console errors (+ the additional 7 added by this changes), I'm afraid we'll have to do something at framework level (e.g. push all border props in the BaseViewManger or something else). Does that clarifies a bit? |
|
Sure, thanks for the clarification. |
jakex7
approved these changes
May 15, 2024
|
Thank you both @jakex7 and @WoLewicki! ❤️ |
jakex7
added a commit
that referenced
this pull request
May 15, 2024
# Summary As per title, when running an app in bridgless mode the following redbox appears: > StaticViewConfigValidator: Invalid static view config for 'RNSVGSvgViewAndroid'. > > 'validAttributes.borderBlockColor' is missing. > 'validAttributes.borderBlockEndColor' is missing. > 'validAttributes.borderBlockStartColor' is missing. > 'validAttributes.borderEndEndRadius' is missing. > 'validAttributes.borderEndStartRadius' is missing. > 'validAttributes.borderStartEndRadius' is missing. > 'validAttributes.borderStartStartRadius' is missing. ## Test Plan Tested that the redbox is gone. ## Compatibility | OS | Implemented | | ------- | :---------: | | iOS | N/A | | Android | ✅ | ## Checklist <!-- Check completed item, when applicable, via: [X] --> - [X] I have tested this on a device and a simulator - [ ] I added documentation in `README.md` - [ ] I updated the typed files (typescript) - [ ] I added a test for the API in the `__tests__` folder --------- Co-authored-by: Jakub Grzywacz <jakub.grzywacz@swmansion.com>
jakex7
added a commit
that referenced
this pull request
May 15, 2024
# Summary As per title, when running an app in bridgless mode the following redbox appears: > StaticViewConfigValidator: Invalid static view config for 'RNSVGSvgViewAndroid'. > > 'validAttributes.borderBlockColor' is missing. > 'validAttributes.borderBlockEndColor' is missing. > 'validAttributes.borderBlockStartColor' is missing. > 'validAttributes.borderEndEndRadius' is missing. > 'validAttributes.borderEndStartRadius' is missing. > 'validAttributes.borderStartEndRadius' is missing. > 'validAttributes.borderStartStartRadius' is missing. ## Test Plan Tested that the redbox is gone. ## Compatibility | OS | Implemented | | ------- | :---------: | | iOS | N/A | | Android | ✅ | ## Checklist <!-- Check completed item, when applicable, via: [X] --> - [X] I have tested this on a device and a simulator - [ ] I added documentation in `README.md` - [ ] I updated the typed files (typescript) - [ ] I added a test for the API in the `__tests__` folder --------- Co-authored-by: Jakub Grzywacz <jakub.grzywacz@swmansion.com>
github-merge-queue bot
referenced
this pull request
in valora-inc/wallet
May 25, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-native-svg](https://togithub.com/react-native-community/react-native-svg) | [`^15.2.0` -> `^15.3.0`](https://renovatebot.com/diffs/npm/react-native-svg/15.2.0/15.3.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>react-native-community/react-native-svg (react-native-svg)</summary> ### [`v15.3.0`](https://togithub.com/software-mansion/react-native-svg/releases/tag/v15.3.0) [Compare Source](https://togithub.com/react-native-community/react-native-svg/compare/v15.2.0...v15.3.0) Minor release fixing some long-standing bugs. Thank you for your contributions! 🎉 #### What's Changed - Add dxguid.lib to release action by [@​Arthurmtro](https://togithub.com/Arthurmtro) in [https://github.com/software-mansion/react-native-svg/pull/2243](https://togithub.com/software-mansion/react-native-svg/pull/2243) - fix: set default strokeWidth to 1 on android by [@​jakex7](https://togithub.com/jakex7) in [https://github.com/software-mansion/react-native-svg/pull/2269](https://togithub.com/software-mansion/react-native-svg/pull/2269) - fix: remove `err` export by [@​jakex7](https://togithub.com/jakex7) in [https://github.com/software-mansion/react-native-svg/pull/2270](https://togithub.com/software-mansion/react-native-svg/pull/2270) - fix: Fix pod install not working with lower version of Cocoapods due to visionOS by [@​jihoon416](https://togithub.com/jihoon416) in [https://github.com/software-mansion/react-native-svg/pull/2240](https://togithub.com/software-mansion/react-native-svg/pull/2240) - fix: Fix static view config validation for RNSVGSvgViewAndroid by [@​fabriziocucci](https://togithub.com/fabriziocucci) in [https://github.com/software-mansion/react-native-svg/pull/2274](https://togithub.com/software-mansion/react-native-svg/pull/2274) - fix: radialGradient `r={0}` by [@​jakex7](https://togithub.com/jakex7) in [https://github.com/software-mansion/react-native-svg/pull/2271](https://togithub.com/software-mansion/react-native-svg/pull/2271) - fix: toDataUrl line breaks by [@​jakex7](https://togithub.com/jakex7) in [https://github.com/software-mansion/react-native-svg/pull/2272](https://togithub.com/software-mansion/react-native-svg/pull/2272) - fix: change android package name by [@​jakex7](https://togithub.com/jakex7) in [https://github.com/software-mansion/react-native-svg/pull/2275](https://togithub.com/software-mansion/react-native-svg/pull/2275) - fix: parsing `<` inside comments by [@​jakex7](https://togithub.com/jakex7) in [https://github.com/software-mansion/react-native-svg/pull/2277](https://togithub.com/software-mansion/react-native-svg/pull/2277) #### New Contributors - [@​Arthurmtro](https://togithub.com/Arthurmtro) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2243](https://togithub.com/software-mansion/react-native-svg/pull/2243) - [@​jakex7](https://togithub.com/jakex7) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2269](https://togithub.com/software-mansion/react-native-svg/pull/2269) - [@​jihoon416](https://togithub.com/jihoon416) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2240](https://togithub.com/software-mansion/react-native-svg/pull/2240) - [@​fabriziocucci](https://togithub.com/fabriziocucci) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2274](https://togithub.com/software-mansion/react-native-svg/pull/2274) **Full Changelog**: software-mansion/react-native-svg@v15.2.0...v15.3.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjguMTAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4zNjguMTAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbIm5wbSIsInJlbm92YXRlIl19--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: valora-bot <valorabot@valoraapp.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As per title, when running an app in bridgless mode the following redbox appears:
Test Plan
Tested that the redbox is gone.
Compatibility
Checklist
README.md__tests__folder