Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change android package name #2275

Merged
merged 3 commits into from
May 15, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
import com.facebook.react.bridge.ReadableMap;
import com.facebook.react.bridge.WritableMap;
import com.facebook.react.module.annotations.ReactModule;
import com.horcrux.rnsvg.NativeSvgRenderableModuleSpec;
import java.io.IOException;
import java.io.InputStream;
import java.io.InputStreamReader;
Expand Down
2 changes: 1 addition & 1 deletion android/src/main/java/com/horcrux/svg/SvgViewModule.java
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
import com.facebook.react.bridge.ReadableMap;
import com.facebook.react.bridge.UiThreadUtil;
import com.facebook.react.module.annotations.ReactModule;
import com.horcrux.rnsvg.NativeSvgViewModuleSpec;
import com.horcrux.svg.NativeSvgViewModuleSpec;
jakex7 marked this conversation as resolved.
Show resolved Hide resolved
import javax.annotation.Nonnull;

@ReactModule(name = SvgViewModule.NAME)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
* @generated by codegen project: GenerateModuleJavaSpec.js
* @nolint
*/
package com.horcrux.rnsvg;
package com.horcrux.svg;

import com.facebook.proguard.annotations.DoNotStrip;
import com.facebook.react.bridge.Promise;
Expand All @@ -17,39 +17,50 @@
import com.facebook.react.bridge.ReactMethod;
import com.facebook.react.bridge.ReadableMap;
import com.facebook.react.bridge.WritableMap;
import com.facebook.react.turbomodule.core.interfaces.TurboModule;
import javax.annotation.Nonnull;
import javax.annotation.Nullable;

public abstract class NativeSvgRenderableModuleSpec extends ReactContextBaseJavaModule
implements TurboModule {
public static final String NAME = "RNSVGRenderableModule";

public abstract class NativeSvgRenderableModuleSpec extends ReactContextBaseJavaModule {
public NativeSvgRenderableModuleSpec(ReactApplicationContext reactContext) {
super(reactContext);
}

@Override
public @Nonnull String getName() {
return NAME;
}

@ReactMethod(isBlockingSynchronousMethod = true)
@DoNotStrip
public abstract boolean isPointInFill(Double tag, ReadableMap options);
public abstract boolean isPointInFill(@Nullable Double tag, @Nullable ReadableMap options);

@ReactMethod(isBlockingSynchronousMethod = true)
@DoNotStrip
public abstract boolean isPointInStroke(Double tag, ReadableMap options);
public abstract boolean isPointInStroke(@Nullable Double tag, @Nullable ReadableMap options);

@ReactMethod(isBlockingSynchronousMethod = true)
@DoNotStrip
public abstract double getTotalLength(Double tag);
public abstract double getTotalLength(@Nullable Double tag);

@ReactMethod(isBlockingSynchronousMethod = true)
@DoNotStrip
public abstract WritableMap getPointAtLength(Double tag, ReadableMap options);
public abstract WritableMap getPointAtLength(@Nullable Double tag, @Nullable ReadableMap options);

@ReactMethod(isBlockingSynchronousMethod = true)
@DoNotStrip
public abstract WritableMap getBBox(Double tag, ReadableMap options);
public abstract WritableMap getBBox(@Nullable Double tag, @Nullable ReadableMap options);

@ReactMethod(isBlockingSynchronousMethod = true)
@DoNotStrip
public abstract WritableMap getCTM(Double tag);
public abstract WritableMap getCTM(@Nullable Double tag);

@ReactMethod(isBlockingSynchronousMethod = true)
@DoNotStrip
public abstract WritableMap getScreenCTM(Double tag);
public abstract WritableMap getScreenCTM(@Nullable Double tag);

@ReactMethod
@DoNotStrip
Expand Down
Original file line number Diff line number Diff line change
@@ -1,28 +1,40 @@

/**
* This code was generated by
* [react-native-codegen](https://www.npmjs.com/package/react-native-codegen).
* This code was generated by [react-native-codegen](https://www.npmjs.com/package/react-native-codegen).
*
* <p>Do not edit this file as changes may cause incorrect behavior and will be lost once the code
* is regenerated.
* Do not edit this file as changes may cause incorrect behavior and will be lost
* once the code is regenerated.
*
* @generated by codegen project: GenerateModuleJavaSpec.js
*
* @nolint
*/
package com.horcrux.rnsvg;

package com.horcrux.svg;

import com.facebook.proguard.annotations.DoNotStrip;
import com.facebook.react.bridge.Callback;
import com.facebook.react.bridge.ReactApplicationContext;
import com.facebook.react.bridge.ReactContextBaseJavaModule;
import com.facebook.react.bridge.ReactMethod;
import com.facebook.react.bridge.ReadableMap;
import com.facebook.react.turbomodule.core.interfaces.TurboModule;
import javax.annotation.Nonnull;
import javax.annotation.Nullable;

public abstract class NativeSvgViewModuleSpec extends ReactContextBaseJavaModule implements TurboModule {
public static final String NAME = "RNSVGSvgViewModule";

public abstract class NativeSvgViewModuleSpec extends ReactContextBaseJavaModule {
public NativeSvgViewModuleSpec(ReactApplicationContext reactContext) {
super(reactContext);
}

@Override
public @Nonnull String getName() {
return NAME;
}

@ReactMethod
@DoNotStrip
public abstract void toDataURL(Double tag, ReadableMap options, Callback callback);
public abstract void toDataURL(@Nullable Double tag, @Nullable ReadableMap options, @Nullable Callback callback);
}
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@
"type": "all",
"jsSrcsDir": "./src/fabric",
"android": {
"javaPackageName": "com.horcrux.rnsvg"
"javaPackageName": "com.horcrux.svg"
}
}
}
Loading