fix: create symlink to common directory #2512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-merge-queue bot
pushed a commit
to software-mansion/react-native-reanimated
that referenced
this pull request
Oct 28, 2024
## Summary Similar to software-mansion/react-native-svg#2512, it fixes resolving local images on Android by creating a symlink to the common directory, allowing images to be resolved without the `../` segment. ## Test plan Run example app on Android and add ```tsx <Image source={require('./assets/doge.png')} /> ``` in `EmptyExample.tsx`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After changing project structure, local images stopped displaying on Android. This is due to the fact that React Native on Android uses okhttp for requests, which modifies the endpoint "by cleaning up the wrong part" from
http://10.0.2.2:8081/../common/example/assets/image.jpgto
http://10.0.2.2:8081/common/example/assets/image.jpgA quick fix for this is to create a symlink to the common directory, allowing images to be resolved without the
../segment.Special thanks to Kudo for sharing the original workaround here: facebook/metro#322 (comment).