Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add macrosPekko and macrosPekkoTests #302

Merged
merged 2 commits into from
Aug 18, 2023

Conversation

kaplanbar
Copy link
Contributor

@kaplanbar kaplanbar commented Aug 17, 2023

Adds macrosPekko and macrosPekkoTests to be used with Pekko.

See: #301

@@ -160,6 +161,14 @@ lazy val macrosAkka = projectMatrix
.jvmPlatform(scalaVersions = scala2)
.jsPlatform(scalaVersions = scala2)

lazy val macrosPekko = projectMatrix
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be included in the root aggregate project list

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂️ I will add it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added.

@adamw
Copy link
Member

adamw commented Aug 18, 2023

Other than the .sbt change I assume it's a direct copy & package change :)

@kaplanbar
Copy link
Contributor Author

Other than the .sbt change I assume it's a direct copy & package change :)

Right, it is just copy paste and fixing the imports.

import akka.* => import org.apache.pekko.*

@adamw adamw merged commit 4ed8bc7 into softwaremill:master Aug 18, 2023
5 checks passed
@adamw
Copy link
Member

adamw commented Aug 18, 2023

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants