Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NH-86008: remove local libs and use remote for joboe #270

Merged
merged 1 commit into from
Oct 15, 2024
Merged

NH-86008: remove local libs and use remote for joboe #270

merged 1 commit into from
Oct 15, 2024

Conversation

cleverchuk
Copy link
Contributor

Tl;dr: use new joboe

Context:

PR adds using joboe from the new repo and I created a new token to be able to read the package.

Test Plan:
Test services data 0, 1, 2 and 3

@cleverchuk cleverchuk requested a review from a team as a code owner October 7, 2024 13:08
cheempz
cheempz approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@cheempz cheempz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, i think once joboe is public its maven packages would also be public and the CI_TOKEN would no longer be needed, is that true?

@cleverchuk cleverchuk merged commit 4f795c5 into main Oct 15, 2024
13 checks passed
@cleverchuk cleverchuk deleted the cc/use-new-joboe branch October 15, 2024 20:01
@cleverchuk cleverchuk restored the cc/use-new-joboe branch October 15, 2024 20:16
@cleverchuk cleverchuk deleted the cc/use-new-joboe branch October 15, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheempz cheempz cheempz approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cleverchuk @cheempz