Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NH-89068: fix nexus plugin #272

Merged
merged 1 commit into from
Oct 9, 2024
Merged

NH-89068: fix nexus plugin #272

merged 1 commit into from
Oct 9, 2024

Conversation

cleverchuk
Copy link
Contributor

@cleverchuk cleverchuk commented Oct 9, 2024 •
edited
Loading

Tl;dr: fix nexus configuration

Context:

Nexus configuration only works on the project's build.gradle file and requires the group id to match what's registered with upstream repository because that's how it figures out the repository's staging profile id.
Move swo agent version to gradle.properties

Test Plan:
Test services data 0, 1, 2 and 3

@cleverchuk cleverchuk requested a review from a team as a code owner October 9, 2024 13:28
cheempz
cheempz approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@cheempz cheempz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR description to demystify what needed to happen.

@cleverchuk cleverchuk merged commit 5c6c9a0 into main Oct 9, 2024
13 checks passed
@cleverchuk cleverchuk deleted the cc/NH-89068 branch October 9, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheempz cheempz cheempz approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cleverchuk @cheempz