Skip to content

Commit

Permalink
dart version bugfix (#4)
Browse files Browse the repository at this point in the history
  • Loading branch information
danylo-safonov-solid authored Sep 14, 2023
1 parent e3fcc02 commit 4637546
Show file tree
Hide file tree
Showing 4 changed files with 18 additions and 9 deletions.
17 changes: 11 additions & 6 deletions .github/workflows/on-pr-push-code-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,9 @@ jobs:

- name: Setup dart
uses: dart-lang/setup-dart@v1
with:
# https://github.com/invertase/dart_edge/issues/50
sdk: 3.0.0

- name: Get main dependencies
run: dart pub get
Expand All @@ -40,12 +43,14 @@ jobs:
with:
fatal-infos: true

- name: Dart Code Metrics
uses: solid-software/dart-code-metrics-action@v5
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
fatal_warnings: true
fatal_style: true
# https://github.com/invertase/dart_edge/issues/50
# dcm action uses stable, which is >=3.1 already, so it doesn't work
# - name: Dart Code Metrics
# uses: solid-software/dart-code-metrics-action@v5
# with:
# github_token: ${{ secrets.GITHUB_TOKEN }}
# fatal_warnings: true
# fatal_style: true

- name: Check formatting
run: dart format . --set-exit-if-changed
4 changes: 3 additions & 1 deletion example/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@ version: 1.0.0
publish_to: none

environment:
sdk: ^3.0.0
# https://github.com/invertase/dart_edge/issues/50
# Tested with 3.0.6, but others should work too
sdk: '>=3.0.0 <3.1.0'

dependencies:
deno_postgres_interop:
Expand Down
4 changes: 3 additions & 1 deletion pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@ version: 0.0.1
repository: https://github.com/solid-software/deno_postgres_interop

environment:
sdk: ^3.0.0
# https://github.com/invertase/dart_edge/issues/50
# Tested with 3.0.6, but others should work too
sdk: '>=3.0.0 <3.1.0'

dev_dependencies:
solid_lints: 0.0.19
2 changes: 1 addition & 1 deletion tools/add_imports/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ description: add_imports.
version: 1.0.0

environment:
sdk: ^3.1.0
sdk: ^3.0.0

dependencies:
args: ^2.4.2
Expand Down

0 comments on commit 4637546

Please sign in to comment.