Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix publish warnings #9

Merged
merged 3 commits into from
Sep 15, 2023
Merged

fix publish warnings #9

merged 3 commits into from
Sep 15, 2023

Conversation

danylo-safonov-solid
Copy link
Collaborator

% dart pub publish --dry-run          
Resolving dependencies...
  _fe_analyzer_shared 61.0.0 (64.0.0 available)
  analyzer 5.13.0 (6.2.0 available)
  analyzer_plugin 0.11.2 (0.11.3 available)
  dart_code_metrics 5.7.5 (5.7.6 available)
  dart_code_metrics_presets 1.8.0 (2.4.0 available)
  dart_style 2.3.2 (2.3.3 available)
  file 6.1.4 (7.0.0 available)
  http 0.13.6 (1.1.0 available)
  process 4.2.4 (5.0.0 available)
  pub_updater 0.3.0 (0.3.1 available)
  uuid 3.0.7 (4.0.0 available)
Got dependencies!
Publishing deno_postgres_interop 0.0.1 to https://pub.dev:
├── CHANGELOG.md (<1 KB)
├── LICENSE (1 KB)
├── README.md (1 KB)
├── add_imports.yaml (<1 KB)
├── analysis_options.yaml (<1 KB)
├── bin
│   └── add_imports.dart (1 KB)
├── example
│   ├── analysis_options.yaml (<1 KB)
│   ├── lib
│   │   └── main.dart (1 KB)
│   └── pubspec.yaml (<1 KB)
├── lib
│   ├── deno_postgres_interop.dart (<1 KB)
│   └── src
│       ├── add_imports
│       │   ├── args.dart (<1 KB)
│       │   └── config.dart (1 KB)
│       ├── client.dart (<1 KB)
│       ├── isolation_level.dart (<1 KB)
│       ├── query_client.dart (2 KB)
│       ├── query_object.dart (1 KB)
│       ├── query_object_result.dart (<1 KB)
│       ├── transaction.dart (1 KB)
│       ├── transaction_options.dart (1 KB)
│       └── util.dart (<1 KB)
└── pubspec.yaml (<1 KB)
Validating package...

Package has 0 warnings.
The server may enforce additional checks.

@danylo-safonov-solid
Copy link
Collaborator Author

@illia-romanenko I'm not sure tho, the add_imports part will only be used as a dev dependency.
But right now, when package will be depended on, the use will also have dependencies of the package in their main dependencies, not dev ones

Comment on lines +12 to +14
args: ^2.4.2
collection: ^1.18.0
yaml: ^3.1.2
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm talking about that. These packages are only used in add_imports, which is only used as a dev script

@danylo-safonov-solid
Copy link
Collaborator Author

danylo-safonov-solid commented Sep 15, 2023

Should we have it asmove it to a separate package instead?

Copy link
Contributor

@illia-romanenko illia-romanenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - when you are ready.

@danylo-safonov-solid danylo-safonov-solid marked this pull request as ready for review September 15, 2023 19:12
@danylo-safonov-solid danylo-safonov-solid merged commit c588ea1 into main Sep 15, 2023
1 check passed
@danylo-safonov-solid danylo-safonov-solid deleted the fix-publish-warnings branch September 15, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants