Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix publish warnings #9

Merged
merged 3 commits into from
Sep 15, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions .github/workflows/on-pr-push-code-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
id: check_files
uses: andstor/file-existence-action@v1
with:
files: 'pubspec.yaml, tools/add_imports/pubspec.yaml'
files: 'pubspec.yaml'

- name: Early exit
if: steps.check_files.outputs.files_exists == 'false'
Expand All @@ -34,10 +34,6 @@ jobs:
- name: Get main dependencies
run: dart pub get

- name: Get add_imports dependencies
run: dart pub get
working-directory: tools/add_imports

- name: Run static code analysis
uses: invertase/github-action-dart-analyzer@v1
with:
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ The main scenario is Supabase Edge Functions, but it should also work for other

4. Add imports to generated file by calling the script:
```bash
dart run tools/add_imports/bin/add_imports.dart
dart run deno_postgres_interop:add_imports \
--filename=example/functions/dart_edge/main.dart.js
```
Note: your filename may differ from the example
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
// This is a CLI tool so it is okay here.
// ignore_for_file: avoid_print

import 'dart:io';

import 'package:add_imports/src/args.dart';
import 'package:add_imports/src/config.dart';
import 'package:args/args.dart';
import 'package:collection/collection.dart';
import 'package:deno_postgres_interop/src/add_imports/args.dart';
import 'package:deno_postgres_interop/src/add_imports/config.dart';
import 'package:yaml/yaml.dart';

void main(List<String> arguments) {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
// This is an internal implementation so it is okay here.
// ignore_for_file: public_member_api_docs

import 'package:args/args.dart';

class Args {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
// This is an internal implementation so it is okay here.
// ignore_for_file: public_member_api_docs

import 'package:collection/collection.dart';
import 'package:yaml/yaml.dart';

Expand Down
7 changes: 6 additions & 1 deletion pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,10 @@ environment:
# Tested with 3.0.6, but others should work too
sdk: '>=3.0.0 <3.1.0'

dependencies:
args: ^2.4.2
collection: ^1.18.0
yaml: ^3.1.2
Comment on lines +12 to +14
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm talking about that. These packages are only used in add_imports, which is only used as a dev script


dev_dependencies:
solid_lints: 0.0.19
solid_lints: ^0.0.19
1 change: 0 additions & 1 deletion tools/add_imports/.gitignore

This file was deleted.

8 changes: 0 additions & 8 deletions tools/add_imports/analysis_options.yaml

This file was deleted.

14 changes: 0 additions & 14 deletions tools/add_imports/pubspec.yaml

This file was deleted.

Loading