Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the clickable zone of the text field #47

Merged
merged 20 commits into from
Jul 4, 2023

Conversation

silverkate
Copy link
Contributor

No description provided.

@solid-vovabeloded
Copy link
Collaborator

It looks like now it is something wrong with the cursor for the text having an error.

Screen.Recording.2023-06-07.at.18.12.19.mov

It looks like if you are focused on a text field, the cursor does not change when you are hovering an error text.

@silverkate
Copy link
Contributor Author

The current behaviour of the cursor seems to be correct. When the focus is on the text field, the cursor is changed to the standard symbol that suggests changing the place where the user enters the text. If I understand the issue in the right way 🤔

And there is an example from the reference ⬇️

Screen.Recording.2023-06-08.at.11.22.38.mov

@solid-danylokhvan
Copy link
Contributor

solid-danylokhvan commented Jun 30, 2023

TEST REPORT

  • When we open the overlay and change the text, the overlay disappears
2023-06-30.22.21.03.mov
  • When we replace the word with the correct one, the cursor should be after the corrected word
2023-06-30.22.23.07.mov
  • When hovering over text with an error, we show the textable cursor
2023-06-30.22.24.21.mov
  • When we tap on the Close icon, we leave the cursor as it was before
2023-06-30.22.26.27.mov
  • We can interact with the text field when the overlay is opened
2023-06-30.22.27.42.mov

Copy link
Collaborator

@solid-yuriiprykhodko solid-yuriiprykhodko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove redundant comments, beside other things.

lib/core/controllers/colored_text_editing_controller.dart Outdated Show resolved Hide resolved
lib/core/controllers/colored_text_editing_controller.dart Outdated Show resolved Hide resolved
lib/core/controllers/colored_text_editing_controller.dart Outdated Show resolved Hide resolved
lib/core/controllers/colored_text_editing_controller.dart Outdated Show resolved Hide resolved
lib/core/controllers/colored_text_editing_controller.dart Outdated Show resolved Hide resolved
lib/core/controllers/colored_text_editing_controller.dart Outdated Show resolved Hide resolved
lib/core/controllers/colored_text_editing_controller.dart Outdated Show resolved Hide resolved
lib/utils/extensions/iterable_extension.dart Outdated Show resolved Hide resolved
Copy link
Collaborator

@solid-yuriiprykhodko solid-yuriiprykhodko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the custom collection util and use the package. Otherwise LGTM.

@solid-danylokhvan solid-danylokhvan merged commit cddfd8e into main Jul 4, 2023
@solid-danylokhvan solid-danylokhvan deleted the feat/improve-word-clickable-zone branch July 4, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants