Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/Intelligent highlight #50

Merged
merged 35 commits into from
Jul 7, 2023
Merged

Feat/Intelligent highlight #50

merged 35 commits into from
Jul 7, 2023

Conversation

solid-danylokhvan
Copy link
Contributor

@solid-danylokhvan solid-danylokhvan commented Jun 27, 2023 •
edited
Loading

2023-06-27.19.55.59.mov

@solid-danylokhvan solid-danylokhvan linked an issue Jun 27, 2023 that may be closed by this pull request
Clear highlight on change intelligently #22
Closed
@solid-danylokhvan solid-danylokhvan changed the title Intelligent highlight Feat/Intelligent highlight Jun 27, 2023
solid-yuriiprykhodko
solid-yuriiprykhodko requested changes Jun 27, 2023
View reviewed changes
Copy link
Collaborator

@solid-yuriiprykhodko solid-yuriiprykhodko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test plan, and provide testing results.

Off the top of my head, we should test:

  • copy-pasting words/sentences
  • editing test in the beginning, middle and end of the text
  • selecting and removing large chunks of text
  • combinations of the above

For all these cases, we must ensure that the custom styling and interactivity works appropriately.

@solid-danylokhvan
Copy link
Contributor Author

TEST REPORT

  1. copy-pasting words/sentences
2023-06-29.19.13.03.mov
  1. editing test in the beginning, middle and end of the text
2023-06-29.19.15.53.mov
  1. selecting and removing large chunks of text
2023-06-29.19.17.15.mov
  1. combinations of the above
2023-06-29.19.18.30.mov

solid-yuriiprykhodko
solid-yuriiprykhodko requested changes Jul 4, 2023
View reviewed changes
lib/implementations/debounce_lang_tool_service.dart Outdated Show resolved Hide resolved
lib/utils/extensions/selection_extension.dart Outdated Show resolved Hide resolved
lib/utils/extensions/selection_extension.dart Outdated Show resolved Hide resolved
solid-yuriiprykhodko
solid-yuriiprykhodko requested changes Jul 5, 2023
View reviewed changes
Copy link
Collaborator

@solid-yuriiprykhodko solid-yuriiprykhodko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot better and easy to reason about.
A few more readability changes and we're good to go.

lib/implementations/keep_latest_response_service.dart Outdated Show resolved Hide resolved
solid-yuriiprykhodko
solid-yuriiprykhodko approved these changes Jul 7, 2023
View reviewed changes
Copy link
Collaborator

@solid-yuriiprykhodko solid-yuriiprykhodko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@solid-danylokhvan solid-danylokhvan merged commit 87ea769 into main Jul 7, 2023
@solid-danylokhvan solid-danylokhvan deleted the feat/intelligent-highlight-2 branch July 7, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@solid-yuriiprykhodko solid-yuriiprykhodko solid-yuriiprykhodko approved these changes

Assignees

@solid-danylokhvan solid-danylokhvan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clear highlight on change intelligently
2 participants
@solid-danylokhvan @solid-yuriiprykhodko