Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arabic Support #75

Merged
merged 6 commits into from
Jan 30, 2024
Merged

Conversation

Semsem-programmer
Copy link
Contributor

@Semsem-programmer Semsem-programmer commented Jan 28, 2024

This fork supports Arabic LanguageToolTextField, with properties:
1- Support Arabic symbols. Showing correctly.
2- Make LanguageToolTextField right to left alignment possible.

Copy link
Contributor

@yurii-prykhodko-solid yurii-prykhodko-solid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition! Left a few comments. Please make sure you run dart format on the checked-in code.

lib/presentation/language_tool_text_field.dart Outdated Show resolved Hide resolved
lib/presentation/language_tool_text_field.dart Outdated Show resolved Hide resolved
lib/client/language_tool_client.dart Outdated Show resolved Hide resolved
Semsem-programmer and others added 3 commits January 29, 2024 22:18
Co-authored-by: Yurii Prykhodko <144313329+yurii-prykhodko-solid@users.noreply.github.com>
Co-authored-by: Yurii Prykhodko <144313329+yurii-prykhodko-solid@users.noreply.github.com>
Copy link
Collaborator

@solid-yuriiprykhodko solid-yuriiprykhodko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@solid-yuriiprykhodko solid-yuriiprykhodko merged commit 6d069be into solid-software:main Jan 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants