Move implementation to src dir
#77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i've got a bunch of errors while testing the example app. doesn't look like my update's fault, but should be fixed in a separate PR 
|
|
Fixed in #78 |
ghost
changed the title
| @@ -19,7 +19,7 @@ dependencies: | |||
| dev_dependencies: | |||
| flutter_test: | |||
| sdk: flutter | |||
| solid_lints: ^0.0.14 | |||
| solid_lints: ^0.1.2 | |||
There was a problem hiding this comment.
Needs CI update.
ghost
commented
Jan 30, 2024
.github/workflows/code_check.yaml
Outdated
Comment on lines
26
to
43
| - name: Setup Dart Code Metrics | ||
| run: dart pub get dart_code_metrics | ||
| - name: Dart Code Metrics | ||
| uses: solid-software/dart-code-metrics-action@bb6c6b9b92f6adbd2b77fd83747a85f1f1be17ca | ||
| with: | ||
| github_token: ${{ secrets.GITHUB_TOKEN }} | ||
| fatal_warnings: true | ||
| fatal_style: true | ||
| folders: "lib" | ||
|
|
||
| - name: Run Dart Code Metrics | ||
| run: | | ||
| dirs_to_analyze="" | ||
| if [ -d lib ]; then dirs_to_analyze+=" lib"; fi | ||
| if [ -d test ]; then dirs_to_analyze+=" test"; fi | ||
| if [ -d example ]; then dirs_to_analyze+=" example"; fi | ||
| if [ dirs_to_analyze != "" ] | ||
| then | ||
| dart run dart_code_metrics:metrics \ | ||
| analyze \ | ||
| $dirs_to_analyze \ | ||
| --fatal-warnings \ | ||
| --fatal-performance \ | ||
| --fatal-style | ||
| fi |
There was a problem hiding this comment.
solid_lints no longer uses DCM.
Add dart run custom_lint.
ghost
requested review from
added 2 commits
January 30, 2024 20:52
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.