Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update throttling dependency #79

Merged
merged 2 commits into from Jan 30, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/implementations/debounce_lang_tool_service.dart
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ class DebounceLangToolService extends LanguageCheckService {
final LanguageCheckService baseService;

/// A debouncing used to debounce the API calls.
final Debouncing debouncing;
final Debouncing<Future<Result<List<Mistake>>?>> debouncing;

/// Creates a new instance of the [DebounceLangToolService] class.
DebounceLangToolService(
Expand All @@ -20,15 +20,15 @@ class DebounceLangToolService extends LanguageCheckService {
@override
Future<Result<List<Mistake>>> findMistakes(String text) async {
final value =
await debouncing.debounce(() => baseService.findMistakes(text))
(await debouncing.debounce(() => baseService.findMistakes(text)) ?? [])
as Result<List<Mistake>>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Casts should be obsolete now.

Suggested change
as Result<List<Mistake>>;
;

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like they don't

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right -- because you're trying to assign a List instead of Result<List> -- so the static analyzer gets confused and downgrades everything to Object.


return value;
}

@override
Future<void> dispose() async {
await debouncing.close();
debouncing.close();
await baseService.dispose();
}
}
2 changes: 1 addition & 1 deletion lib/implementations/throttling_lang_tool_service.dart
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ class ThrottlingLangToolService extends LanguageCheckService {

@override
Future<void> dispose() async {
await throttling.close();
throttling.close();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Throttling has a generic arg too, let's remove the typecast

await baseService.dispose();
}
}
2 changes: 1 addition & 1 deletion pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ dependencies:
flutter:
sdk: flutter
http: ^1.0.0
throttling: ^1.0.0
throttling: ^2.0.1

dev_dependencies:
flutter_test:
Expand Down
Loading