Add missing tests for custom_lint #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n-bernat
commented
Aug 10, 2023
Comment on lines
+36
to
+40
| reporter.reportErrorForOffset( | ||
| code, | ||
| node.firstTokenAfterCommentAndMetadata.offset, | ||
| node.end, | ||
| ); |
There was a problem hiding this comment.
We need a custom match for a specific offset, because otherwise in this case it would also match a comment above it
n-bernat
commented
Aug 10, 2023
solid-yuriiprykhodko
approved these changes
Aug 10, 2023
solid-yuriiprykhodko
merged commit dd98c87
into
solid-software:release-v0.1.0
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
// expect_lintallows us to specify that on the following line there should be a match. It returns an error if the line below that is not matched. If it's matched then this line is ignored.