Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support custom reactive functions for reactivity rule #113

Merged
merged 1 commit into from
Dec 30, 2023
Merged

Support custom reactive functions for reactivity rule #113

merged 1 commit into from
Dec 30, 2023

Conversation

CreativeTechGuy
Copy link
Contributor

Fix #112

@joshwilsonvu
Copy link
Collaborator

Thank you for this PR and your patience! Though this isn't the approach I'd like to use in the long-term, I'd like to merge this to alleviate this pain point in the short-term. I don't expect many users to need it, given the use* and create* escape hatches, but no harm done in having it.

@joshwilsonvu joshwilsonvu merged commit 20a0e83 into solidjs-community:main Dec 30, 2023
@joshwilsonvu joshwilsonvu mentioned this pull request Dec 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable customizing reactive rule to treat certain custom functions as reactive
2 participants
@CreativeTechGuy @joshwilsonvu