fix: makeSearchRegex Memory leak (due to empty capture) (#682)

solidjs-community · Sep 4, 2024 · b4eada7 · b4eada7
2 parents c7256a9 + a1f602d
commit b4eada7
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.changeset/selfish-eagles-train.md b/.changeset/selfish-eagles-train.md
@@ -0,0 +1,5 @@
+---
+"@solid-primitives/marker": minor
+---
+
+fix memory leak
diff --git a/packages/marker/src/index.ts b/packages/marker/src/index.ts
@@ -16,7 +16,7 @@ export function makeSearchRegex(search: string): RegExp {
   return search
     ? new RegExp(
         // join words `|` to match any of them
-        search.replace(SPLIT_WORDS_REGEX, "|"),
+        search.trim().replace(SPLIT_WORDS_REGEX, "|"),
         "gi",
       )
     : NEVER_REGEX;