Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite build script to build all packages in one process (Removes CJS) #701

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

thetarnav
Copy link
Member

Rewrites build script to build all packages in one process
Similarly to how testing works
So no turborepo cashing, but it's much faster overall
5s to build all packages instead of a couple of minutes
So should be much easier for new people to fork and build locally and not have to wait so much
Also website deploys could happen on main now as the netlify build should be a lot faster

Proper turbo-like caching could be added later as well and be used for tests too, without sacrificing the time to build all packages.

Please run rm -rf packages/*/dist/* and rm -rf .turbo to clear old outputs

This also removes CJS support

Copy link

changeset-bot bot commented Sep 29, 2024

🦋 Changeset detected

Latest commit: b62866d

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@atk
Copy link
Member

atk commented Sep 29, 2024

Since the removal of CJS support might be considered a breaking change, shouldn't this be a major update? Minor breaking changes are a violation of semver.

Also, in CONTRIBUTING.md, the design maxim number 12 still includes CJS support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants